Configurable, uniquely-classed caption delimiters - #838
Merged
Conversation
Add an `i18n_delim(type, default)` helper that resolves a caption delimiter from `@i18n.get["<type>_delimiter"] || @i18n.get["caption_delimiter"] || default` (optional keys via `@i18n.get`, so default behaviour is unchanged unless a flavour/document sets them). Route the clause delimiter and the per-asset caption delimiters (note, table, figure, subfigure, termnote, annex, example, admonition, sourcecode) through it. Give the terminal clause-number delimiter its own `fmt-clause-delim` class, distinct from the `fmt-autonum-delim` used for the internal `1.1.1` separators, so it is uniquely targetable in XSLT/CSS. Spec fixture updates (terminal-delim class rename across presentation-XML and HTML fixtures) still pending. Refs metanorma/metanorma-pdfa#51
This was referenced Aug 11, 2026
PDF XSL: render the new fmt-clause-delim terminal clause delimiter class
metanorma/metanorma-pdfa#88
Closed
opoudjis
added a commit
to metanorma/metanorma-ribose
that referenced
this pull request
Aug 17, 2026
Set clause_delimiter to "" in the ribose i18n dictionary and drop the now-redundant BaseConvert#clausedelim override. The delimiter is applied in the presentation-XML stage (single source of truth), so PDF/FO output honours it too — fixing the period that previously appeared only in the presentation-consuming outputs. Prefers YAML config over inheritor code. Requires isodoc >= 3.7.2 (configurable clause_delimiter, metanorma/isodoc#838). Refs metanorma/metanorma-pdfa#74
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs metanorma/metanorma-pdfa#51
Make caption delimiters configurable per caption type via i18n, and give the terminal clause-number delimiter its own
fmt-clause-delimclass — distinct from thefmt-autonum-delimused for the internal1.1.1separators — so it is uniquely targetable in XSLT/CSS.i18n_delim(type, default)resolves@i18n.get["<type>_delimiter"] || @i18n.get["caption_delimiter"] || default(keys optional via@i18n.get, so default output is unchanged unless a flavour/document sets them).clause_delimiter: ""removes the terminal period after clause numbers (1.2.3.→1.2.3) — the metanorma-pdfa#51 request — for both PDF and HTML.Spec fixtures updated for the terminal-delimiter class rename.
Follow-ups (separate): document
fmt-clause-delimin the isodoc-presentation grammar, the new i18n labels on metanorma.org, and the PDF-XSL handling offmt-clause-delim.🤖